[PATCH net-next v10 10/15] net: phy: marvell10g: Support SFP through phy_port

[Maxime Chevallier]

On Sat, 26 Jul 2025 23:17:11 +0200
Andrew Lunn <andrew at lunn.ch> wrote:

> > +	} else if (port->not_described) {
> > +		/* This PHY can do combo-ports, i.e. 2 MDI outputs, usually one
> > +		 * of them going to an SFP and the other one to a RJ45
> > +		 * connector. If we don't have any representation for the port
> > +		 * in DT, and we are dealing with a non-SFP port, then we
> > +		 * mask the port's capabilities to report BaseT-only modes
> > +		 */
> > +		port->mediums = BIT(ETHTOOL_LINK_MEDIUM_BASET);
> > +
> > +		phy_port_filter_supported(port);  
> 
> That seems a little bit error prone. Maybe add a helper to set
> port->mediums, which also makes the phy_port_filter_supported() call?

Good point, as this will always have to be done in similar situations
for other drivers.

I'll add that, thanks !

Maxime