[PATCH v3 3/5] dt-bindings: power: supply: add max77759-fg flavor

Thomas Antoine t.antoine at uclouvain.be
Wed Apr 30 06:51:33 PDT 2025


Hello,

On 4/23/25 15:45, Krzysztof Kozlowski wrote:
> On 23/04/2025 10:05, Thomas Antoine wrote:
>> On 4/22/25 12:05, Krzysztof Kozlowski wrote:
>>> On Mon, Apr 21, 2025 at 08:13:34PM GMT, Thomas Antoine wrote:
>>>> +allOf:
>>>> +  - $ref: power-supply.yaml#
>>>> +  - if:
>>>> +      properties:
>>>> +        compatible:
>>>> +          contains:
>>>> +            enum:
>>>> +              - maxim,max17201
>>>> +    then:
>>>> +      properties:
>>>> +        reg:
>>>> +          minItems: 2
>>>> +          maxItems: 2
>>>> +  - if:
>>>> +      properties:
>>>> +        compatible:
>>>> +          contains:
>>>> +            enum:
>>>> +              - maxim,max77759-fg
>>>> +    then:
>>>> +      properties:
>>>> +        reg:
>>>> +          items:
>>>> +            minItems: 1
>>> If there is going to be resend, drop minItems.
>>>
>> Will drop it in v4.
>>
> One more thing - your reg-names are now incorrectly constrained - where
> are their constraints?
> 
> You need to test your bindings and DTS before you post. If by any chance
> community robots found more issues (e.g. you sent something untested),
> you should address it.
> 
> 
> Best regards,
> Krzysztof

I did run the test but I obviously must have done it wrong. I will check it out
such that it does not happen again.

Best regards,
Thomas



More information about the linux-arm-kernel mailing list