[PATCH 1/3] dt-bindings: clock: exynosautov920: add cpucl1/2 clock definitions

손신 shin.son at samsung.com
Mon Apr 28 03:41:20 PDT 2025


Hello Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzk at kernel.org]
> Sent: Monday, April 28, 2025 6:13 PM
> To: Shin Son <shin.son at samsung.com>; Sylwester Nawrocki
> <s.nawrocki at samsung.com>; Chanwoo Choi <cw00.choi at samsung.com>; Alim
> Akhtar <alim.akhtar at samsung.com>; Michael Turquette
> <mturquette at baylibre.com>; Stephen Boyd <sboyd at kernel.org>; Rob Herring
> <robh at kernel.org>; Conor Dooley <conor+dt at kernel.org>; Sunyeal Hong
> <sunyeal.hong at samsung.com>
> Cc: linux-samsung-soc at vger.kernel.org; linux-clk at vger.kernel.org;
> devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-
> kernel at vger.kernel.org
> Subject: Re: [PATCH 1/3] dt-bindings: clock: exynosautov920: add cpucl1/2
> clock definitions
> 
> On 28/04/2025 10:47, Shin Son wrote:
> > Add cpucl1 and cpucl2 clock definitions.
> >
> > CPUCL1/2 refer to CPU Cluster 1 and CPU Cluster 2, which provide clock
> > support for the CPUs on Exynosauto V920 SoC.
> 
> You should have sent all cpcl0-2 together, so we see complete picture.
> 
> >
> > Signed-off-by: Shin Son <shin.son at samsung.com>
> > ---
> >  .../clock/samsung,exynosautov920-clock.yaml   | 45 +++++++++++++++++++
> >  .../clock/samsung,exynosautov920.h            | 32 +++++++++++++
> >  2 files changed, 77 insertions(+)
> >
> 
> 
> ...
> 
> > +    then:
> > +      properties:
> > +        clocks:
> > +          items:
> > +            - description: External reference clock (38.4 MHz)
> > +            - description: CMU_CPUCL2 SWITCH clock (from CMU_TOP)
> > +            - description: CMU_CPUCL2 CLUSTER clock (from CMU_TOP)
> > +
> > +        clock-names:
> > +          items:
> > +            - const: oscclk
> > +            - const: switch
> > +            - const: cluster
> > +
> > +
> Just one blank line.
> 
> Best regards,
> Krzysztof

Thanks for the feedback.
I will group related patches together next time for a more complete view.
I will also remove the extra blank line and resend the patch.

Best regards,
Shin Son




More information about the linux-arm-kernel mailing list