[PATCH 1/1] arm64: dts: allwinner: correct the model name for Radxa Cubie A5E
Chen-Yu Tsai
wens at csie.org
Fri Apr 25 08:27:39 PDT 2025
On Fri, Apr 25, 2025 at 12:47 PM Yixun Lan <dlan at gentoo.org> wrote:
>
> Hi Chukun, Chen-Yu,
>
> On 11:52 Fri 25 Apr , Chen-Yu Tsai wrote:
> > On Fri, Apr 25, 2025 at 11:00 AM Chukun Pan <amadeus at jmu.edu.cn> wrote:
> > >
> > > Hi,
> > >
> > > > It seems I'm a little bit late for this, but while we are here,
> > > > Can we also append 'cubie' to dts file name?
> > > > e.g. - sun55i-a527-radxa-cubie-a5e.dts
> > >
> > > Usually we use the device name (without the vendor name),
> > > maybe sun55i-a527-cubie-a5e.dts would be better?
> >
> > I agree with this one.
> >
> I personally would prefer to keep vendor name, it's more explicit
> and easy for poeple to distinguish/find the board dts
We really only have the board name, which sometimes combines a brand
name, but not the vendor name.
Same goes for all of Radxa's other Rockchip boards. The file names
are all rk3xxx-rock?????.dts. And all the LibreELEC boards are
????-nanopi-???.dts.
ChenYu
> but, this isn't something I really care, so I won't insist on this,
> please proceed either way, thanks
>
> > I can probably squash in a name change (since I'll be squashing in the
> > SD card slot fix anyway). Andre?
> >
> I think it is better
>
> >
> > In that case would you prefer to keep your current patch separate, or
> > squashed in so that everything is clean from the first commit?
> >
> > It's up to you since you lose out on commit stats.
> >
> >
> > Thanks
> > ChenYu
> >
> > > Thanks,
> > > Chukun
> > >
> > > --
> > > 2.25.1
> > >
> > >
>
> --
> Yixun Lan (dlan)
>
More information about the linux-arm-kernel
mailing list