[PATCH v3 2/3] PCI: dw-rockchip: Reorganize register and bitfield definitions

Niklas Cassel cassel at kernel.org
Wed Apr 23 10:50:16 PDT 2025


On Wed, Apr 23, 2025 at 11:32:13PM +0800, Hans Zhang wrote:
> Register definitions were scattered with ambiguous names (e.g.,
> PCIE_RDLH_LINK_UP_CHGED in PCIE_CLIENT_INTR_STATUS_MISC) and lacked
> hierarchical grouping. Magic values for bit operations reduced code
> clarity.
> 
> Group registers and their associated bitfields logically. This improves
> maintainability and aligns the code with hardware documentation.
> 
> Signed-off-by: Hans Zhang <18255117159 at 163.com>
> ---

Reviewed-by: Niklas Cassel <cassel at kernel.org>



More information about the linux-arm-kernel mailing list