[PATCH v11 12/18] clk: imx: add support for i.MX8MN anatop clock driver

Dan Carpenter dan.carpenter at linaro.org
Wed Apr 23 06:12:33 PDT 2025


On Wed, Apr 23, 2025 at 08:02:29AM +0200, Dario Binacchi wrote:
> -	hws[IMX8MN_CLK_DUMMY] = imx_clk_hw_fixed("dummy", 0);
> -	hws[IMX8MN_CLK_24M] = imx_get_clk_hw_by_name(np, "osc_24m");
> -	hws[IMX8MN_CLK_32K] = imx_get_clk_hw_by_name(np, "osc_32k");
> +	hws[IMX8MN_CLK_DUMMY] = imx_anatop_get_clk_hw(anp, IMX8MN_ANATOP_CLK_DUMMY);
> +	hws[IMX8MN_CLK_24M] = imx_anatop_get_clk_hw(anp, IMX8MN_ANATOP_CLK_24M);
> +	hws[IMX8MN_CLK_32K] = imx_anatop_get_clk_hw(anp, IMX8MN_ANATOP_CLK_32K);

I'm just CC'd on the v11 of this one patch and I really hate to nit-pick
a v11 patch...  But I don't love that there are so many unrelated little
cleanups mixed in with the functional changes.

I also don't care strongly about something which is self contained in a
vendor driver and I recognize that re-writing patches is a pain in the
neck.

regards,
dan carpenter



More information about the linux-arm-kernel mailing list