[PATCH 2/8] net: octeontx2: Use pure PCI devres API

Philipp Stanner phasta at mailbox.org
Wed Apr 23 01:38:01 PDT 2025


On Wed, 2025-04-23 at 08:28 +0200, Philipp Stanner wrote:
> On Tue, 2025-04-22 at 17:49 -0700, Jakub Kicinski wrote:
> > On Wed, 16 Apr 2025 18:44:02 +0200 Philipp Stanner wrote:
> > >  err_release_regions:
> > >  	pci_set_drvdata(pdev, NULL);
> > > -	pci_release_regions(pdev);
> > 
> > This error path should be renamed. Could you also apply your
> > conversion
> > to drivers/net/ethernet/marvell/octeontx2/af/ ?
> 
> Hm, those must have slipped me for some reason. Will reiterate with
> them and the error path.

Wait, false alarm. I actually did look at them and those in af/ don't
seem to use the combination of pcim_enable_device() + pci_request_*

Only users of that combination have to be ported. Users of
pci_enable_device() + pcim_* functions and pcim_enable_device() +
pcim_* functions are fine.

Correct me if I missed the first mentioned combination up there.

P.

> 
> P.
> 




More information about the linux-arm-kernel mailing list