[PATCH v2 4/6] iio: adc: ad7380: use IIO_DECLARE_BUFFER_WITH_TS

Andy Shevchenko andy.shevchenko at gmail.com
Tue Apr 22 15:53:11 PDT 2025


On Wed, Apr 23, 2025 at 1:41 AM David Lechner <dlechner at baylibre.com> wrote:
> On 4/22/25 5:33 PM, Andy Shevchenko wrote:
> > On Wed, Apr 23, 2025 at 1:08 AM David Lechner <dlechner at baylibre.com> wrote:

...

> >> +       IIO_DECLARE_BUFFER_WITH_TS(u8, scan_data, MAX_NUM_CHANNELS * sizeof(u32))
> >
> > Btw, why not DECLARE_IIO_...() as other DECLARE_*() look like?
>
> IMHO, namespace should always go first and people who write DECLARE_NS_... are
> doing it wrong. :-)

Not really. AFAICT it depends on the globality of the macro. Those,
which are defined in types.h are all DECLARE_something(). Which makes
sense. So the Q here is if the IIO macros like these ever go out for a
wider audience. But in any case this can be amended later (with maybe
a bit of additional churn).

> There is not existing DECLARE_IIO_ to match anyway.

True.

-- 
With Best Regards,
Andy Shevchenko



More information about the linux-arm-kernel mailing list