[PATCH v3 2/3] arm64: dts: ti: Add basic support for phyBOARD-Izar-AM68x

[Kumar, Udit]

Hi Dominik,


On 4/22/2025 9:14 PM, Dominik Haller wrote:
> On Sun, 2025-04-20 at 10:08 +0530, Kumar, Udit wrote:
>> Hello Dominik,
>>
>> Thanks for patch.
>>
>> Few minor feedback
> Hello Udit,
>
> thanks for the feedback.
>> On 4/17/2025 6:29 PM, Dominik Haller wrote:
>>> The phyCORE-AM68x/TDA4x [1] is a SoM (System on Module) featuring
>>> TI's
>>> AM68x/TDA4x SoC. It can be used in combination with different
>>> carrier
>>> boards. This module can come with different sizes and models for
>>> DDR,
>>> eMMC, SPI NOR Flash and various SoCs from the AM68x/TDA4x (J721S2)
>>> family.
>>>
>>> A reference carrier board design, called phyBOARD-Izar is used for
>>> the
>>> phyCORE-AM68x/TDA4x development kit [2].
>>>
>>> Supported features:
>>> * Debug UART
>>> * 2x SPI NOR Flash
>>> * eMMC
>>> * 2x Ethernet
>>> * Micro SD card
>>> * I2C EEPROM
>>> * I2C RTC
>>> * 2x I2C GPIO Expander
>>> * LEDs
>>> * USB 5 Gbit/s
>>> * PCIe
>>>
>>> For more details see the product pages for the SoM and the
>>> development kit:
>>>
>>> [1]
>>> https://www.phytec.eu/en/produkte/system-on-modules/phycore-am68x-tda4x/
>>> [2]
>>> https://www.phytec.eu/en/produkte/development-kits/phyboard-izar/
>>>
>>> Signed-off-by: Dominik Haller <d.haller at phytec.de>
>>> Acked-by: Moteen Shah <m-shah at ti.com>
>>> ---
>>>
>>> Notes:
>>>       Bootlog:
>>>
>>> [..]
>>> Please have bootph-all in case, this is boot device
> I only plan to add OSPI0 as boot source in mainline U-boot since
> booting from OSPI1/QSPI won't work with the same binaries.

Ok,


>>
>>> [..]
>>> +
>>> +   wkup_uart0_pins_default: wkup-uart0-default-pins {
>>> +           pinctrl-single,pins = <
>>> +                   J721S2_WKUP_IOPAD(0x070, PIN_INPUT, 0) /*
>>> (E25) WKUP_GPIO0_6.WKUP_UART0_CTSn */
>>> +                   J721S2_WKUP_IOPAD(0xas OSPI1/QSPI needs at
>>> least a different CONFIG_SF_DEFAULT_BUS.074, PIN_OUTPUT, 0) /*
>>> (F28) WKUP_GPIO0_7.WKUP_UART0_RTSn */
>>> +                   J721S2_WKUP_IOPAD(0x048, PIN_INPUT, 0) /*
>>> (D28) WKUP_UART0_RXD */
>>> +                   J721S2_WKUP_IOPAD(0x04c, PIN_OUTPUT, 0) /*
>>> (D27) WKUP_UART0_TXD */
>>> +           >;
>>> +           bootph-all;
>> Since this is shared with TIFS fw (debug prints), then i suggest not
>> to
>> have flow control on this UART
> So if you see the flow control pins causing issues with tifs I'll drop
> them. And if you recommend setting the wkup_uart0 to "reserved" in the
> devicetree by default to begin with I'll do that too.

For debug port, often flow control is not used.

I am not sure, what use case you are targeting with wkup_uart0.

But if possible , I suggest to leave this for fw usage,

reference EVM you can refer at below

https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts#L322 



>>
>>> +   };
>>> +};
>>> [..]