[PATCH net-next v3 1/2] net: stmmac: Refactor VLAN implementation

Ng, Boon Khai boon.khai.ng at altera.com
Mon Apr 21 09:52:12 PDT 2025


> > I can confirm that 802.1ad (QinQ) has been broken on stmmac for years,
> > and it will be so nice if this refactoring includes some fixes for
> > QinQ
> 
> FWIIW, please be sure that fixes are separate patches from refactoring.

Hi Furong, Simon,

This refactor is intended to combine the VLAN driver for dwmac4 and 
dwxgmac2. From our perspective, on our board, we do not actually
use the QinQ feature of the xgmac2 IP.

However, I agree with Simon that the fixes should be separate from
the refactoring process

Regards,
Boon Khai.




More information about the linux-arm-kernel mailing list