[PATCH v3 2/2] arm64: dts: allwinner: a64: Add WiFi/BT header on SoPine

Peter Robinson pbrobinson at gmail.com
Sun Apr 20 10:42:53 PDT 2025


On Sun, 20 Apr 2025 at 18:17, Dragan Simic <dsimic at manjaro.org> wrote:
>
> Hello Peter,
>
> On 2025-04-20 11:33, Peter Robinson wrote:
> >> > This adds all the pin mappings on the WiFi/BT header on
> >> > the SoPine baseboard/A64-LTS. They're disabled by default
> >> > as the modules don't ship by default. This includes, where
> >> > they haven't been already, UART1 for BT and mmc1 for WiFi.
> >>
> >> The patch subject should be improved a bit, to include
> >> "Baseboard" as well.  Having just "SoPine" is a bit too
> >> vague, and it should actually be written as "SOPINE"
> >> at all places in the prose.
> >
> > It literally has baseboard in the second line of the description.
>
> True, but the patch subject should also contain "Baseboard",
> because SOPINE is a system on module, and the SOPINE Baseboard
> turns it into an SBC that actually has the add-on headers that
> the patch addresses.  I hope it makes sense.

I mean it's pretty clear from the file that is being patched, I think
you're splitting hairs here, but I've already updated it in v4



More information about the linux-arm-kernel mailing list