[PATCH 10/10] iio: chemical: atlas-sensor: use struct with aligned_s64 timestamp
David Lechner
dlechner at baylibre.com
Fri Apr 18 12:58:29 PDT 2025
Use a struct with aligned s64_timestamp instead of a padded array for
the buffer used for iio_push_to_buffers_with_ts(). This makes it easier
to see the correctness of the size and alignment of the buffer.
Signed-off-by: David Lechner <dlechner at baylibre.com>
---
drivers/iio/chemical/atlas-sensor.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/chemical/atlas-sensor.c b/drivers/iio/chemical/atlas-sensor.c
index cb6662b9213740f4a88b8412e6a0f01bc5a314d6..a67783ce7f1b68135e05d3afc05533d400d4a052 100644
--- a/drivers/iio/chemical/atlas-sensor.c
+++ b/drivers/iio/chemical/atlas-sensor.c
@@ -17,6 +17,7 @@
#include <linux/i2c.h>
#include <linux/mod_devicetable.h>
#include <linux/regmap.h>
+#include <linux/types.h>
#include <linux/iio/iio.h>
#include <linux/iio/buffer.h>
#include <linux/iio/trigger.h>
@@ -91,8 +92,10 @@ struct atlas_data {
struct regmap *regmap;
struct irq_work work;
unsigned int interrupt_enabled;
- /* 96-bit data + 32-bit pad + 64-bit timestamp */
- __be32 buffer[6] __aligned(8);
+ struct {
+ __be32 data[3];
+ aligned_s64 timestamp;
+ } buffer;
};
static const struct regmap_config atlas_regmap_config = {
@@ -455,10 +458,10 @@ static irqreturn_t atlas_trigger_handler(int irq, void *private)
int ret;
ret = regmap_bulk_read(data->regmap, data->chip->data_reg,
- &data->buffer, sizeof(__be32) * channels);
+ data->buffer.data, sizeof(__be32) * channels);
if (!ret)
- iio_push_to_buffers_with_ts(indio_dev, data->buffer,
+ iio_push_to_buffers_with_ts(indio_dev, &data->buffer,
sizeof(data->buffer),
iio_get_time_ns(indio_dev));
--
2.43.0
More information about the linux-arm-kernel
mailing list