[PATCH v2 2/2] vsprintf: remove redundant and unused %pCn format specifier
Daniel Lezcano
daniel.lezcano at linaro.org
Fri Apr 18 03:08:34 PDT 2025
On Tue, Apr 08, 2025 at 09:33:57AM +0200, Petr Mladek wrote:
> On Mon 2025-04-07 18:46:47, Luca Ceresoli wrote:
> > Hello Petr, Daniel,
> >
> > On Tue, 11 Mar 2025 15:36:11 +0100
> > Petr Mladek <pmladek at suse.com> wrote:
> >
> > > On Tue 2025-03-11 10:21:23, Luca Ceresoli wrote:
> > > > %pC and %pCn print the same string, and commit 900cca294425 ("lib/vsprintf:
> > > > add %pC{,n,r} format specifiers for clocks") introducing them does not
> > > > clarify any intended difference. It can be assumed %pC is a default for
> > > > %pCn as some other specifiers do, but not all are consistent with this
> > > > policy. Moreover there is now no other suffix other than 'n', which makes a
> > > > default not really useful.
> > > >
> > > > All users in the kernel were using %pC except for one which has been
> > > > converted. So now remove %pCn and all the unnecessary extra code and
> > > > documentation.
> > > >
> > > > Acked-by: Stephen Boyd <sboyd at kernel.org>
> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas at glider.be>
> > > > Signed-off-by: Luca Ceresoli <luca.ceresoli at bootlin.com>
> > >
> > > Makes sense. Looks and works well, so:
> > >
> > > Reviewed-by: Petr Mladek <pmladek at suse.com>
> > > Tested-by: Petr Mladek <pmladek at suse.com>
> > >
> > > Daniel, if I get it correctly, you have already taken the 1st patch.
> > > Would you mind to take also this patch using the same tree, please?
> > > Otherwise, we would need to coordinate pull requests in the upcoming
> > > merge window ;-)
> >
> > I see none of these two patches in linux-next.
>
> I see.
>
> > Anything I should do? Resend? Or just wait a bit more?
>
> Daniel, Rafael, Zhang, Lukasz,
>
> would you like to take both patches via the linux-pm.git thermal tree?
> Or should I take both patches via the printk tree?
> Both ways work for me.
I'll take care of them now
Thanks for the heads up
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
More information about the linux-arm-kernel
mailing list