[PATCH v6 09/10] arm64: dts: cix: add initial CIX P1(SKY1) dts support

Krzysztof Kozlowski krzk at kernel.org
Wed Apr 16 23:18:44 PDT 2025


On 15/04/2025 09:27, Peter Chen wrote:
> +
> +		mbox_ap2pm: mailbox at 6590080 {
> +			compatible = "cix,sky1-mbox";
> +			reg = <0x0 0x06590080 0x0 0xff80>;
> +			interrupts = <GIC_SPI 363 IRQ_TYPE_LEVEL_HIGH 0>;
> +			#mbox-cells = <1>;
> +			cix,mbox-dir = "tx";
> +		};
> +
> +		pm2ap_scmi_mem: pm2ap-shmem at 65a0000 {
> +			compatible = "arm,scmi-shmem";
> +			#address-cells = <2>;
> +			#size-cells = <2>;
> +			reg-io-width = <4>;
> +			reg = <0x0 0x065a0000 0x0 0x80>;

Messed order of properties. Keep it consistent (see DTS conding style).
Other nodes also have oddly placed reg.



Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list