[PATCH] gpio: nomadik: Add check for clk_enable()
Bartosz Golaszewski
brgl at bgdev.pl
Mon Apr 14 11:30:40 PDT 2025
On Mon, Apr 14, 2025 at 2:11 PM Chenyuan Yang <chenyuan0y at gmail.com> wrote:
>
> On Mon, Apr 14, 2025 at 4:24 AM Théo Lebrun <theo.lebrun at bootlin.com> wrote:
> >
> > As for why irq_startup returns an unsigned int, I am unsure. The kernel
> > Git history isn't enough to know more. The startup field in struct
> > hw_interrupt_type appeared on v2.3.14 [2], so no commit message to
> > explain decisions.
> >
> > Seeing the __irq_startup() code, my proposal would be to turn the return
> > value to a signed int, but I haven't exhaustively checked codepaths.
>
> Good catch! I agree that using a signed int could be a better option.
>
> Dear Linus and Bartosz, could you please share your thoughts? If
> you’re on board with the change, I’ll go ahead and send a new patch.
>
Ok, I'm backing out this one then.
Bartosz
More information about the linux-arm-kernel
mailing list