[RFC 3/5] dt-bindings: power: Add binding for MediaTek MT7988 topmisc power controller
AngeloGioacchino Del Regno
angelogioacchino.delregno at collabora.com
Mon Apr 14 03:25:23 PDT 2025
Il 13/04/25 10:58, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w at public-files.de>
>
> Topmisc is a systemcontroller used for xs-phy and ethernet on mt7988.
> Add binding for it.
That's the wrong binding... check mfd/syscon.yaml :-)
P.S.: Is there any reset controller in topmisc? Any clock?
If yes, syscon.yaml is also wrong, and you need a driver for that.
Remember: If it turns out *later* that this has clk/resets and the
bindings are already set for just a syscon, it's gonna be way harder!
Cheers,
Angelo
>
> Signed-off-by: Frank Wunderlich <frank-w at public-files.de>
> ---
> .../power/mediatek,power-controller.yaml | 35 +++++++++++++------
> 1 file changed, 24 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> index 591a080ca3ff..60d2fc7963e5 100644
> --- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> +++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> @@ -22,17 +22,27 @@ properties:
> pattern: '^power-controller(@[0-9a-f]+)?$'
>
> compatible:
> - enum:
> - - mediatek,mt6735-power-controller
> - - mediatek,mt6795-power-controller
> - - mediatek,mt8167-power-controller
> - - mediatek,mt8173-power-controller
> - - mediatek,mt8183-power-controller
> - - mediatek,mt8186-power-controller
> - - mediatek,mt8188-power-controller
> - - mediatek,mt8192-power-controller
> - - mediatek,mt8195-power-controller
> - - mediatek,mt8365-power-controller
> + oneOf:
> + - items:
> + - enum:
> + - mediatek,mt6735-power-controller
> + - mediatek,mt6795-power-controller
> + - mediatek,mt8167-power-controller
> + - mediatek,mt8173-power-controller
> + - mediatek,mt8183-power-controller
> + - mediatek,mt8186-power-controller
> + - mediatek,mt8188-power-controller
> + - mediatek,mt8192-power-controller
> + - mediatek,mt8195-power-controller
> + - mediatek,mt8365-power-controller
> + - items:
> + - enum:
> + - mediatek,mt7988-topmisc
> + - const: syscon
> + - const: mediatek,mt7988-power-controller
> +
> + reg:
> + maxItems: 1
>
> '#power-domain-cells':
> const: 1
> @@ -43,6 +53,9 @@ properties:
> '#size-cells':
> const: 0
>
> + '#clock-cells':
> + const: 1
> +
> patternProperties:
> "^power-domain@[0-9a-f]+$":
> $ref: "#/$defs/power-domain-node"
More information about the linux-arm-kernel
mailing list