[PATCH v4 01/10] dt-bindings: phy: add exynos2200 eusb2 phy support

[Krzysztof Kozlowski]

On Sat, Apr 12, 2025 at 11:26:11PM GMT, Ivaylo Ivanov wrote:
> Document the exynos2200 eUSB2 compatible. Unlike the currently documented
> Qualcomm SoCs, the driver doesn't make use of reset lines for reset
> control and uses more clocks.
> 
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1 at gmail.com>
> ---
>  .../bindings/phy/samsung,snps-eusb2-phy.yaml  | 79 +++++++++++++++++++
>  1 file changed, 79 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/samsung,snps-eusb2-phy.yaml

Please name it after compatible, so
samsung,exynos2200-eusb2-phy.yaml


> 
> diff --git a/Documentation/devicetree/bindings/phy/samsung,snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,snps-eusb2-phy.yaml
> new file mode 100644
> index 000000000..09d3fdd4a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/samsung,snps-eusb2-phy.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/samsung,snps-eusb2-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung SNPS eUSB2 phy controller
> +
> +maintainers:
> +  - Ivaylo Ivanov <ivo.ivanov.ivanov1 at gmail.com>
> +
> +description:
> +  eUSB2 controller supports LS/FS/HS usb connectivity on Exynos2200.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - samsung,exynos2200-snps-eusb2-phy

I did not mention this earlier, but I think we should skip the snps in
the compatible. Using vendor name in device name is just confusing, so:

samsung,exynos2200-eusb2-phy

However the description should include it, e.g.

Samsung Exynos2200 eUSB2 phy, based on Synopsys eUSB2 IP block, ....


...

> +additionalProperties: false
> +
> +examples:
> +  - |
> +    usb_hsphy: phy at 10ab0000 {
> +        compatible = "samsung,exynos2200-snps-eusb2-phy";
> +        reg = <0x10ab0000 0x10000>;
> +        #phy-cells = <0>;
> +
> +        clocks = <&cmu_hsi0 7>,
> +            <&cmu_hsi0 5>,
> +            <&cmu_hsi0 8>;

These should be aligned with opening <

With above:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>

Best regards,
Krzysztof