[PATCH v5 3/3] arm64: dts: freescale: Add minimal dts support for imx943 evk

[Jacky Bai]

> Subject: Re: [PATCH v5 3/3] arm64: dts: freescale: Add minimal dts support for
> imx943 evk
>
> Hi,
>
> Am Donnerstag, 10. April 2025, 08:28:26 CEST schrieb Jacky Bai:
> > Add the minimal board dts support for i.MX943 EVK. Only the console
> > uart, SD & eMMC are enabled for linux basic boot.
> >
> > Signed-off-by: Jacky Bai <ping.bai at nxp.com>
> > Reviewed-by: Frank Li <Frank.Li at nxp.com>
> > ---
> >  - v5 changes:
> >   - remove the unused and not documented 'fsl,cd-gpio-wakeup-disable'
> >     property from usdhc node.
> >
> >  - v4 changes:
> >   - no
> >
> >  - v3 changes:
> >   - no
> >
> >  - v2 changes:
> >   - newly added for board dts
> > ---
> >  arch/arm64/boot/dts/freescale/Makefile       |   1 +
> >  arch/arm64/boot/dts/freescale/imx943-evk.dts | 195
> > +++++++++++++++++++
> >  2 files changed, 196 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx943-evk.dts
> >
> > diff --git a/arch/arm64/boot/dts/freescale/Makefile
> > b/arch/arm64/boot/dts/freescale/Makefile
> > index b6d3fe26d621..2fe86fc6d73a 100644
> > --- a/arch/arm64/boot/dts/freescale/Makefile
> > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > @@ -303,6 +303,7 @@ dtb-$(CONFIG_ARCH_MXC) +=
> > imx93-tqma9352-mba93xxla.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx93-var-som-symphony.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx95-15x15-evk.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx95-19x19-evk.dtb
> > +dtb-$(CONFIG_ARCH_MXC) += imx943-evk.dtb
>
> Uh, please sort the entries alphabetically, thus imx94 goes before imx95.
>

Ok

> >
> >  imx8mm-kontron-dl-dtbs                     := imx8mm-kontron-bl.dtb
> imx8mm-kontron-dl.dtbo
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx943-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx943-evk.dts
> > new file mode 100644
> > index 000000000000..b0bb08bb67d5
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx943-evk.dts
...

> > +&usdhc1 {
> > +   pinctrl-0 = <&pinctrl_usdhc1>;
> > +   pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
> > +   pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
> > +   pinctrl-3 = <&pinctrl_usdhc1>;
> > +   pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep";
>
> Is the sleep pinctrl necessary if it is the same as 'default'?
>

Currently not necessary, I can drop it.

> > +   bus-width = <8>;
> > +   non-removable;
> > +   no-sdio;
> > +   no-sd;
> > +   status = "okay";
> > +};
> > +
> > +&usdhc2 {
> > +   pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
> > +   pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>;
> > +   pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
> > +   pinctrl-3 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
> > +   pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep";
>
> Same here.
>
> > +   bus-width = <4>;
> > +   cd-gpios = <&gpio4 20 GPIO_ACTIVE_LOW>;
> > +   vmmc-supply = <&reg_usdhc2_vmmc>;
>
> This is probably also 'no-mmc', no? Maybe even 'no-sdio'.
>

This slot is used for SD card, will update it as you suggested in next version. Thx.

BR

> Best regards,
> Alexander
>
> > +   status = "okay";
> > +};
> > +
> > +&wdog3 {
> > +   fsl,ext-reset-output;
> > +   status = "okay";
> > +};
> >
>
>
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-g/
> roup.com%2F&data=05%7C02%7Cping.bai%40nxp.com%7Cb24c8157d23c4d95
> b9a508dd77fb70f0%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> 8798643991989017%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRyd
> WUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%
> 3D%7C0%7C%7C%7C&sdata=wtlbuuuZBHYRvl7SF0GGH5CPI2oFGSURWSG6ZZ4
> EBqg%3D&reserved=0
>