> +static u16 dwxgmac2_wrback_get_rx_vlan_tci(struct dma_desc *p) > +{ > + return (le32_to_cpu(p->des0) & XGMAC_RDES0_VLAN_TAG_MASK); > +} This appears to be identical to dwmac4_wrback_get_rx_vlan_tci() ? Can it be moved into the shared code, or am i missing something? Andrew