[PATCH hyperv-next v7 01/11] arm64: kvm, smccc: Introduce and use API for getting hypervisor UUID

Roman Kisel romank at linux.microsoft.com
Tue Apr 8 09:16:16 PDT 2025



On 4/8/2025 12:06 AM, Marc Zyngier wrote:
> On Mon, 07 Apr 2025 21:13:26 +0100,
> Roman Kisel <romank at linux.microsoft.com> wrote:

[...]

>>   
>>   #include <linux/args.h>
>>   #include <linux/init.h>
>> +
>> +#ifndef __ASSEMBLER__
>> +#include <linux/uuid.h>
>> +#endif
> 
> That's a pretty unusual guard in arm64 land. Looking at the current
> state of the kernel:
> 
> $ git grep -w __ASSEMBLER__ arch/arm64/ | wc -l
> 2
> $ git grep -w __ASSEMBLY__ arch/arm64/ | wc -l
> 122
> 
> I'd suggest the later rather than the former.

Thanks for catching this! I'll be sure to change this to use the arm64
coding conventions in the next version.

> 
> Thanks,
> 
> 	M.
> 

-- 
Thank you,
Roman




More information about the linux-arm-kernel mailing list