[PATCH net-next v4 05/11] net: ti: prueth: Adds ethtool support for ICSSM PRUETH Driver

[Keller, Jacob E]

> -----Original Message-----
> From: Andrew Lunn <andrew at lunn.ch>
> Sent: Monday, April 7, 2025 1:19 PM
> To: Parvathi Pudi <parvathi at couthit.com>
> Cc: danishanwar at ti.com; rogerq at kernel.org; andrew+netdev at lunn.ch;
> davem at davemloft.net; Dumazet, Eric <edumazet at google.com>;
> kuba at kernel.org; pabeni at redhat.com; robh at kernel.org; krzk+dt at kernel.org;
> conor+dt at kernel.org; nm at ti.com; ssantosh at kernel.org; tony at atomide.com;
> richardcochran at gmail.com; glaroque at baylibre.com; schnelle at linux.ibm.com;
> m-karicheri2 at ti.com; rdunlap at infradead.org; diogo.ivo at siemens.com;
> basharath at couthit.com; horms at kernel.org; Keller, Jacob E
> <jacob.e.keller at intel.com>; m-malladi at ti.com; javier.carrasco.cruz at gmail.com;
> afd at ti.com; s-anna at ti.com; linux-arm-kernel at lists.infradead.org;
> netdev at vger.kernel.org; devicetree at vger.kernel.org; linux-
> kernel at vger.kernel.org; linux-omap at vger.kernel.org; pratheesh at ti.com;
> prajith at ti.com; vigneshr at ti.com; praneeth at ti.com; srk at ti.com; rogerq at ti.com;
> krishna at couthit.com; pmohan at couthit.com; mohan at couthit.com
> Subject: Re: [PATCH net-next v4 05/11] net: ti: prueth: Adds ethtool support for
> ICSSM PRUETH Driver
> 
> > +#define PRUETH_MODULE_VERSION "0.2"
> 
> > +static void icssm_emac_get_drvinfo(struct net_device *ndev,
> > +				   struct ethtool_drvinfo *info)
> > +{
> > +	strscpy(info->driver, PRUETH_MODULE_DESCRIPTION, sizeof(info-
> >driver));
> > +	strscpy(info->version, PRUETH_MODULE_VERSION, sizeof(info->version));
> 
> Driver version numbers are pointless, they never change, but the
> kernel is changing all the time. Leave version blank, and the core
> will fill in the kernel version, which is useful.
> 
>      Andrew

It is also a long standing policy that in-tree drivers should not have versions separate from the kernel version.

Thanks,
Jake