[PATCH v3] media: platform: exynos4-is: Use of_get_available_child_by_name()

[Biju Das]

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk at kernel.org>
> Sent: 07 April 2025 14:30
> Subject: Re: [PATCH v3] media: platform: exynos4-is: Use of_get_available_child_by_name()
> 
> On 07/04/2025 13:05, Biju Das wrote:
> > Simplify fimc_md_is_isp_available() by using
> > of_get_available_child_by_name().
> >
> > Signed-off-by: Biju Das <biju.das.jz at bp.renesas.com>
> > ---
> > v2->v3:
> >  * Fixed CHECK: Comparison to NULL could be written "child" reoported by
> >    [1]
> > https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/741
> > 16132/artifacts/report.htm
> >  * Dropped Rb tag from Krzysztof.
> And what is the reason? Minor tweak for checkpatch? Really?

Just to have your second opinion, I dropped the Rb tag even though it is minor
as the patch got rejected see[1].

[1]
Thanks for your patches! Unfortunately the Media CI robot detected some
issues:

# Test checkpatch:./0001-media-platform-exynos4-is-Use-of_get_available_child.patch checkpatch
CHECK: Comparison to NULL could be written "child"
#28: FILE: drivers/media/platform/samsung/exynos4-is/media-dev.h:183:
+return child != NULL;

total: 0 errors, 0 warnings, 1 checks, 10 lines checked



Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.

For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/74116132/artifacts/report.htm .


Cheers,
Biju