[PATCH v3 11/32] mfd: sec: fix open parenthesis alignment (multiple)

Lee Jones lee at kernel.org
Fri Apr 4 02:27:43 PDT 2025


On Thu, 03 Apr 2025, André Draszik wrote:

> checkpatch complains about unexpected alignment issues in this file -

Fine, but either call it by it's name 'Checkpatch' or the command 'checkpatch.pl'.

> update the code accordingly.

This phrasing and grammar is odd.  How about?

  Subject: mfd: sec-common: Fix multiple trivial whitespace issues

  Rectify a couple of alignment problems reported by Checkpatch.

> Signed-off-by: André Draszik <andre.draszik at linaro.org>
> 
> ---
> v2:
> * make new alignment more readable (Krzysztof)
> ---
>  drivers/mfd/sec-common.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c
> index 782dec1956a5fd7bf0dbb2159f9d222ad3fea942..1a6f14dda825adeaeee1a677459c7399c144d553 100644
> --- a/drivers/mfd/sec-common.c
> +++ b/drivers/mfd/sec-common.c
> @@ -149,9 +149,9 @@ sec_pmic_parse_dt_pdata(struct device *dev)
>  		return ERR_PTR(-ENOMEM);
>  
>  	pd->manual_poweroff = of_property_read_bool(dev->of_node,
> -						"samsung,s2mps11-acokb-ground");
> +						    "samsung,s2mps11-acokb-ground");
>  	pd->disable_wrstbi = of_property_read_bool(dev->of_node,
> -						"samsung,s2mps11-wrstbi-ground");
> +						   "samsung,s2mps11-wrstbi-ground");
>  	return pd;
>  }
>  
> @@ -264,8 +264,8 @@ void sec_pmic_shutdown(struct device *dev)
>  		 * ignore the rest.
>  		 */
>  		dev_warn(sec_pmic->dev,
> -			"Unsupported device %lu for manual power off\n",
> -			sec_pmic->device_type);
> +			 "Unsupported device %lu for manual power off\n",
> +			 sec_pmic->device_type);
>  		return;
>  	}
>  
> 
> -- 
> 2.49.0.472.ge94155a9ec-goog
> 

-- 
Lee Jones [李琼斯]



More information about the linux-arm-kernel mailing list