[PATCH v2] dt-bindings: pwm: Convert lpc32xx-pwm.txt to YAML

[Uwe Kleine-König]

Hello,

On Wed, Mar 12, 2025 at 05:57:50PM +0530, Purva Yeshi wrote:
> Convert the existing `lpc32xx-pwm.txt` bindings documentation into a
> YAML schema (`nxp,lpc3220-pwm.yaml`).
> 
> Set `"#pwm-cells"` to `const: 3` for expected PWM cell properties.
> 
> Signed-off-by: Purva Yeshi <purvayeshi550 at gmail.com>

I suggest the following commit log:

    dt-bindings: pwm: Convert lpc32xx-pwm.txt to yaml format

    Convert the existing plain text binding documentation for
    nxp,lpc3220-pwm devices to a YAML schema.

    The value #pwm-cells wasn't specified before, set it to 3 to match the
    usual value for PWMs.

> diff --git a/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml b/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
> new file mode 100644
> index 000000000..432a5e9d4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/nxp,lpc3220-pwm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LPC32XX PWM controller
> +
> +maintainers:
> +  - Vladimir Zapolskiy <vz at mleia.com>
> +  - Piotr Wojtaszczyk <piotr.wojtaszczyk at timesys.com>
> +
> +allOf:
> +  - $ref: pwm.yaml#
> +
> +properties:
> +  compatible:
> +    const: nxp,lpc3220-pwm
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#pwm-cells":
> +    const: 3

The PWMs defined in arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi also have a
clocks property and in the driver it's not optional. Can you please add
it (here, in the list of required properties and the commit log)?

> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    pwm at 4005c000 {
> +        compatible = "nxp,lpc3220-pwm";
> +        reg = <0x4005c000 0x4>;
> +        #pwm-cells = <3>;
> +    };

Best regards
Uwe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20250403/4d2ef3dd/attachment.sig>