[PATCH v2 3/4] PCI: imx6: Pass correct sub mode when calling phy_set_mode_ext()

[Hongxing Zhu]

> -----Original Message-----
> From: Frank Li <frank.li at nxp.com>
> Sent: 2024年9月24日 2:59
> To: Lorenzo Pieralisi <lpieralisi at kernel.org>; Krzysztof Wilczyński
> <kw at linux.com>; Manivannan Sadhasivam
> <manivannan.sadhasivam at linaro.org>; Rob Herring <robh at kernel.org>;
> Bjorn Helgaas <bhelgaas at google.com>; Krzysztof Kozlowski
> <krzk+dt at kernel.org>; Conor Dooley <conor+dt at kernel.org>; Abraham I
> <kishon at kernel.org>; Saravana Kannan <saravanak at google.com>; Jingoo
> Han <jingoohan1 at gmail.com>; Gustavo Pimentel
> <gustavo.pimentel at synopsys.com>; Jesper Nilsson
> <jesper.nilsson at axis.com>; Hongxing Zhu <hongxing.zhu at nxp.com>; Lucas
> Stach <l.stach at pengutronix.de>; Shawn Guo <shawnguo at kernel.org>;
> Sascha Hauer <s.hauer at pengutronix.de>; Pengutronix Kernel Team
> <kernel at pengutronix.de>; Fabio Estevam <festevam at gmail.com>
> Cc: linux-pci at vger.kernel.org; devicetree at vger.kernel.org;
> linux-kernel at vger.kernel.org; linux-arm-kernel at axis.com;
> linux-arm-kernel at lists.infradead.org; imx at lists.linux.dev; Krzysztof
> Wilczyński <kwilczynski at kernel.org>; Frank Li <frank.li at nxp.com>
> Subject: [PATCH v2 3/4] PCI: imx6: Pass correct sub mode when calling
> phy_set_mode_ext()
> 
> Fix hardcoding to Root Complex (RC) mode by adding a drvdata mode check.
> Pass PHY_MODE_PCIE_EP if the PCI controller operates in Endpoint (EP)
> mode.
> 
> Fixes: 8026f2d8e8a9 ("PCI: imx6: Call common PHY API to set mode, speed,
> and submode")
> Signed-off-by: Frank Li <Frank.Li at nxp.com>

Reviewed-by: Richard Zhu <hongxing.zhu at nxp.com>

Best Regards
Richard Zhu
> ---
>  drivers/pci/controller/dwc/pci-imx6.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c
> b/drivers/pci/controller/dwc/pci-imx6.c
> index 808d1f1054173..bdc2b372e6c13 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -961,7 +961,9 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp)
>  			goto err_clk_disable;
>  		}
> 
> -		ret = phy_set_mode_ext(imx_pcie->phy, PHY_MODE_PCIE,
> PHY_MODE_PCIE_RC);
> +		ret = phy_set_mode_ext(imx_pcie->phy, PHY_MODE_PCIE,
> +				       imx_pcie->drvdata->mode ==
> DW_PCIE_EP_TYPE ?
> +						PHY_MODE_PCIE_EP : PHY_MODE_PCIE_RC);
>  		if (ret) {
>  			dev_err(dev, "unable to set PCIe PHY mode\n");
>  			goto err_phy_exit;
> 
> --
> 2.34.1