[PATCH v1 1/9] dt-bindings: imx6q-pcie: Add ref clock for i.MX95 PCIe

[Hongxing Zhu]

> -----Original Message-----
> From: Conor Dooley <conor at kernel.org>
> Sent: 2024年9月25日 0:04
> To: Frank Li <frank.li at nxp.com>
> Cc: Hongxing Zhu <hongxing.zhu at nxp.com>; l.stach at pengutronix.de;
> kwilczynski at kernel.org; bhelgaas at google.com; lpieralisi at kernel.org;
> robh+dt at kernel.org; conor+dt at kernel.org; shawnguo at kernel.org;
> krzysztof.kozlowski+dt at linaro.org; festevam at gmail.com;
> s.hauer at pengutronix.de; linux-pci at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org;
> devicetree at vger.kernel.org; kernel at pengutronix.de; imx at lists.linux.dev
> Subject: Re: [PATCH v1 1/9] dt-bindings: imx6q-pcie: Add ref clock for i.MX95
> PCIe
> 
> On Tue, Sep 24, 2024 at 11:23:06AM -0400, Frank Li wrote:
> > On Tue, Sep 24, 2024 at 11:08:20AM +0100, Conor Dooley wrote:
> > > On Tue, Sep 24, 2024 at 11:27:36AM +0800, Richard Zhu wrote:
> > > > Add one ref clock for i.MX95 PCIe. Increase clocks' maxItems to 5
> > > > and keep the same restriction with other compatible string.
> > > >
> > > > Signed-off-by: Richard Zhu <hongxing.zhu at nxp.com>
> > >
> > > It'd be really good to mention why this clock is appearing now, when
> > > it did not before. You're just explaining what you've done, which
> > > can be seen in the diff, but not why you did it.
> >
> > Previous reference clock of i.MX95 is on when system boot to kernel.
> > But boot firmware change the behavor, so it is off when boot. So it
> > need be turn on when it use. Also it need be turn off/on when suspend and
> resume.
> > Previous miss this feature.
> 
> Please put this in the commit message Richard.
Hi Conor:
Thanks for your comments.
Would add these information in the commit message later.

Best Regards
Richard Zhu
> 
> Thanks,
> Conor.