[PATCH] net: xilinx: axienet: Use common error handling code in axienet_mdio_write()

[Simon Horman]

On Fri, Sep 20, 2024 at 01:01:45PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring at users.sourceforge.net>
> Date: Fri, 20 Sep 2024 12:43:39 +0200
> Subject: [PATCH] net: xilinx: axienet: Use common error handling code in axienet_mdio_write()
> 
> Add a label so that a bit of exception handling can be better reused
> at the end of this function implementation.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring at users.sourceforge.net>


Hi Markus,

This change seems reasonable to me.  However, I am assuming that as a
non-bug-fix, this is targeted at net-next.  And net-next is currently
closed for the v6.12 merge window.  Please consider reposting this patch
once net-next reopens.  That will occur after v6.12-rc1 has been released.
Which I expect to be about a week from now.

Also, for networking patches please tag non-bug fixes for
net-next (and bug fixes for net, being sure to include a Fixes tag).

	Subject: [PATCH net-next] ...

Please see https://docs.kernel.org/process/maintainer-netdev.html

...

> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c

...

> @@ -153,12 +151,9 @@ static int axienet_mdio_write(struct mii_bus *bus, int phy_id, int reg,
>  		     XAE_MDIO_MCR_OP_WRITE_MASK));
> 
>  	ret = axienet_mdio_wait_until_ready(lp);
> -	if (ret < 0) {
> -		axienet_mdio_mdc_disable(lp);
> -		return ret;
> -	}

Please add a blank line here.

> +disable_mdc:
>  	axienet_mdio_mdc_disable(lp);
> -	return 0;
> +	return ret;
>  }
> 
>  /**

-- 
pw-bot: defer