[PATCH] arm64: uprobes: Optimize cache flushes for xol slot
Oleg Nesterov
oleg at redhat.com
Thu Sep 19 07:18:25 PDT 2024
On 09/19, Liao Chang wrote:
>
> --- a/arch/arm64/kernel/probes/uprobes.c
> +++ b/arch/arm64/kernel/probes/uprobes.c
> @@ -17,12 +17,16 @@ void arch_uprobe_copy_ixol(struct page *page, unsigned long vaddr,
> void *xol_page_kaddr = kmap_atomic(page);
> void *dst = xol_page_kaddr + (vaddr & ~PAGE_MASK);
>
> + if (!memcmp(dst, src, len))
> + goto done;
can't really comment, I know nothing about arm64...
but don't we need to change __create_xol_area()
- area->page = alloc_page(GFP_HIGHUSER);
+ area->page = alloc_page(GFP_HIGHUSER | __GFP_ZERO);
to avoid the false positives?
Oleg.
More information about the linux-arm-kernel
mailing list