[PATCH net] net: airoha: fix PSE memory configuration in airoha_fe_pse_ports_init()

Lorenzo Bianconi lorenzo at kernel.org
Thu Sep 19 05:58:15 PDT 2024


> On Wed, Sep 18, 2024 at 04:37:30PM +0200, Lorenzo Bianconi wrote:
> > Align PSE memory configuration to vendor SDK. In particular, increase
> > initial value of PSE reserved memory in airoha_fe_pse_ports_init()
> > routine by the value used for the second Packet Processor Engine (PPE2)
> > and do not overwrite the default value.
> > Moreover, store the initial value for PSE reserved memory in orig_val
> > before running airoha_fe_set_pse_queue_rsv_pages() in
> > airoha_fe_set_pse_oq_rsv routine.
> 
> Hi Lorenzo,

Hi Simon,

> 
> This patch seems to be addressing two issues, perhaps it would be best
> to split it into two patches?

ack, I will do.

> 
> And as a fix (or fixes) I think it would be best to describe the
> problem, typically a user-visible bug, that is being addressed.

This is not a user-visible bug, do you think it is better to post it to
net-next (when it is open)?

Regards,
Lorenzo

> 
> > Fixes: 23020f049327 ("net: airoha: Introduce ethernet support for EN7581 SoC")
> > Tested-by: Sayantan Nandy <sayantan.nandy at airoha.com>
> > Signed-off-by: Lorenzo Bianconi <lorenzo at kernel.org>
> 
> ...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20240919/27a1d073/attachment.sig>


More information about the linux-arm-kernel mailing list