[PATCH 03/21] dt-bindigs: arm64: adi,sc598 bindings

Krzysztof Kozlowski krzk at kernel.org
Sun Sep 15 23:44:24 PDT 2024


On 12/09/2024 20:24, Arturs Artamonovs via B4 Relay wrote:
> From: Arturs Artamonovs <arturs.artamonovs at analog.com>
> 
> Bindigs for ADI ADSP-SC5xx reset controller

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

It is dt-bindings: soc: adi:... if it was in soc.


> 
> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs at analog.com>
> Co-developed-by: Utsav Agarwal <Utsav.Agarwal at analog.com>
> Signed-off-by: Utsav Agarwal <Utsav.Agarwal at analog.com>
> Co-developed-by: Nathan Barrett-Morrison <nathan.morrison at timesys.com>
> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison at timesys.com>
> Co-developed-by: Greg Malysa <greg.malysa at timesys.com>
> Signed-off-by: Greg Malysa <greg.malysa at timesys.com>
> ---
>  .../bindings/soc/adi/adi,reset-controller.yaml     | 38 ++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/adi/adi,reset-controller.yaml b/Documentation/devicetree/bindings/soc/adi/adi,reset-controller.yaml

Nope, don't just dump stuff to soc. This is reset controller so goes to
reset.

> new file mode 100644
> index 0000000000000000000000000000000000000000..7a6df1cfb709d818d5e3dbcd202938d6aaaaaa9b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/adi/adi,reset-controller.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/adi/adi,reset-controller.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices Reset Controller for SC5XX processor family
> +
> +maintainers:
> +  - Arturs Artamonovs <arturs.artamonovs at analog.com>
> +  - Utsav Agarwal <Utsav.Agarwal at analog.com>
> +
> +description: |
> +  SHARC and ARM core reset control unit for starting/stopping/resetting
> +  processors
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,reset-controller
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    rcu: rcu at 3108c000 {

Drop unused label.

> +      compatible = "adi,reset-controller";
> +      reg = <0x3108c000 0x1000>;
> +      status = "okay";

Drop

> +    };
> +
> 

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list