[PATCH net-next] net: ethtool: phy: Clear the netdev context pointer for DUMP requests
Maxime Chevallier
maxime.chevallier at bootlin.com
Fri Sep 13 00:14:04 PDT 2024
Hello Jakub,
On Thu, 12 Sep 2024 20:44:38 -0700
Jakub Kicinski <kuba at kernel.org> wrote:
> On Wed, 11 Sep 2024 15:46:21 +0200 Maxime Chevallier wrote:
> > + /* Clear the context netdev pointer so avoid a netdev_put from
> > + * the .done() callback
> > + */
> > + ctx->phy_req_info->base.dev = NULL;
>
> Why do we assign to req_base.dev in the first place?
> req is for the parsed request in my mind, and I don't
> see anything in the PHY dump handlers actually using dev?
After reading the code back, that's true. It's just a leftover from
when I hadn't considered that dumps could be interrupted/resumed.
Let me clean that up then.
Thanks for the review Jakub,
Maxime
More information about the linux-arm-kernel
mailing list