[PATCH v3 18/24] KVM: arm64: Split S1 permission evaluation into direct and hierarchical parts

[Marc Zyngier]

On Wed, 11 Sep 2024 15:15:13 +0100,
Joey Gouly <joey.gouly at arm.com> wrote:
> 
> On Wed, Sep 11, 2024 at 02:51:45PM +0100, Marc Zyngier wrote:

[...]

> > +static void compute_s1_hierarchical_permissions(struct kvm_vcpu *vcpu,
> > +						struct s1_walk_info *wi,
> > +						struct s1_walk_result *wr,
> > +						struct s1_perms *s1p)
> > +{
> 
> How about:
> 
> 	if (wi->hpd)
> 		return;

I was hoping not to add anything like this, because all the table bits
are 0 (we simply don't collect them), and thus don't have any effect.

Or did you spot any edge case where that would result in in a
different set of permissions?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.