[arm-platforms:kvm-arm64/asahi-base-6.11 23/29] drivers/tty/serial/samsung_tty.c:2087:3: warning: misleading indentation; statement is not part of the previous 'if'

kernel test robot lkp at intel.com
Wed Sep 11 03:11:17 PDT 2024


tree:   https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git kvm-arm64/asahi-base-6.11
head:   0619e126e13837cf7e2cc8dfda13d762d37dc10a
commit: ce041b76229de01c9de3bd890e2710b59f23bf1c [23/29] Revert "fixup! tty: serial: samsung_tty: Support runtime PM"
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240911/202409111822.YAWw8dDO-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240911/202409111822.YAWw8dDO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409111822.YAWw8dDO-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/tty/serial/samsung_tty.c:2087:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
    2087 |                 uart_remove_one_port(&s3c24xx_uart_drv, port);
         |                 ^
   drivers/tty/serial/samsung_tty.c:2085:2: note: previous statement is here
    2085 |         if (port)
         |         ^
   1 warning generated.


vim +/if +2087 drivers/tty/serial/samsung_tty.c

b497549a035c2a drivers/serial/samsung.c         Ben Dooks        2008-07-03  2079  
77772addc1f110 drivers/tty/serial/samsung_tty.c Uwe Kleine-König 2023-11-10  2080  static void s3c24xx_serial_remove(struct platform_device *dev)
b497549a035c2a drivers/serial/samsung.c         Ben Dooks        2008-07-03  2081  {
b497549a035c2a drivers/serial/samsung.c         Ben Dooks        2008-07-03  2082  	struct uart_port *port = s3c24xx_dev_to_port(&dev->dev);
9df94f66b70292 drivers/tty/serial/samsung_tty.c Hector Martin    2021-09-20  2083  	struct s3c24xx_uart_port *ourport = to_ourport(port);
b497549a035c2a drivers/serial/samsung.c         Ben Dooks        2008-07-03  2084  
ce041b76229de0 drivers/tty/serial/samsung_tty.c Marc Zyngier     2024-07-30  2085  	if (port)
9df94f66b70292 drivers/tty/serial/samsung_tty.c Hector Martin    2021-09-20  2086  		pm_runtime_get_sync(&dev->dev);
b497549a035c2a drivers/serial/samsung.c         Ben Dooks        2008-07-03 @2087  		uart_remove_one_port(&s3c24xx_uart_drv, port);
b497549a035c2a drivers/serial/samsung.c         Ben Dooks        2008-07-03  2088  
9df94f66b70292 drivers/tty/serial/samsung_tty.c Hector Martin    2021-09-20  2089  		clk_disable_unprepare(ourport->clk);
9df94f66b70292 drivers/tty/serial/samsung_tty.c Hector Martin    2021-09-20  2090  		if (!IS_ERR(ourport->baudclk))
9df94f66b70292 drivers/tty/serial/samsung_tty.c Hector Martin    2021-09-20  2091  			clk_disable_unprepare(ourport->baudclk);
9df94f66b70292 drivers/tty/serial/samsung_tty.c Hector Martin    2021-09-20  2092  
9df94f66b70292 drivers/tty/serial/samsung_tty.c Hector Martin    2021-09-20  2093  		pm_runtime_disable(&dev->dev);
9df94f66b70292 drivers/tty/serial/samsung_tty.c Hector Martin    2021-09-20  2094  		pm_runtime_set_suspended(&dev->dev);
9df94f66b70292 drivers/tty/serial/samsung_tty.c Hector Martin    2021-09-20  2095  		pm_runtime_put_noidle(&dev->dev);
9df94f66b70292 drivers/tty/serial/samsung_tty.c Hector Martin    2021-09-20  2096  
6f134c3c770355 drivers/tty/serial/samsung.c     Tushar Behera    2014-01-20  2097  	uart_unregister_driver(&s3c24xx_uart_drv);
b497549a035c2a drivers/serial/samsung.c         Ben Dooks        2008-07-03  2098  }
b497549a035c2a drivers/serial/samsung.c         Ben Dooks        2008-07-03  2099  

:::::: The code at line 2087 was first introduced by commit
:::::: b497549a035c2a81b71c7a27f2b00c8a16c09423 [ARM] S3C24XX: Split serial driver into core and per-cpu drivers

:::::: TO: Ben Dooks <ben-linux at fluff.org>
:::::: CC: Ben Dooks <ben-linux at fluff.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



More information about the linux-arm-kernel mailing list