[PATCH v5 2/3] firmware: xilinx: Add Pinctrl Get Attribute ID

[Thangaraj, Senthil Nathan]

Hi Sai Krishna,

Please find my review below.

Thanks,
Senthil

> -----Original Message-----
> From: linux-arm-kernel <linux-arm-kernel-bounces at lists.infradead.org> On
> Behalf Of Sai Krishna Potthuri
> Sent: Friday, September 6, 2024 4:01 AM
> To: Linus Walleij <linus.walleij at linaro.org>; Simek, Michal
> <michal.simek at amd.com>; Rob Herring <robh at kernel.org>; Krzysztof
> Kozlowski <krzk+dt at kernel.org>; Conor Dooley <conor+dt at kernel.org>;
> Buddhabhatti, Jay <jay.buddhabhatti at amd.com>; Kundanala, Praveen Teja
> <praveen.teja.kundanala at amd.com>; Greg Kroah-Hartman
> <gregkh at linuxfoundation.org>
> Cc: linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org; linux-
> gpio at vger.kernel.org; devicetree at vger.kernel.org;
> saikrishna12468 at gmail.com; git (AMD-Xilinx) <git at amd.com>; Potthuri, Sai
> Krishna <sai.krishna.potthuri at amd.com>
> Subject: [PATCH v5 2/3] firmware: xilinx: Add Pinctrl Get Attribute ID
> 
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
> 
> 
> Add Pinctrl Get Attribute ID to the query ids list.
> 
> Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri at amd.com>
> ---
>  include/linux/firmware/xlnx-zynqmp.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/firmware/xlnx-zynqmp.h
> b/include/linux/firmware/xlnx-zynqmp.h
> index d7d07afc0532..3b4ce4ec5d3f 100644
> --- a/include/linux/firmware/xlnx-zynqmp.h
> +++ b/include/linux/firmware/xlnx-zynqmp.h
> @@ -238,6 +238,7 @@ enum pm_query_id {
>         PM_QID_PINCTRL_GET_PIN_GROUPS = 11,
>         PM_QID_CLOCK_GET_NUM_CLOCKS = 12,
>         PM_QID_CLOCK_GET_MAX_DIVISOR = 13,
> +       PM_QID_PINCTRL_GET_ATTRIBUTES = 15,

Any reason why do you need to skip 14 and use 15 here ?

>  };
> 
>  enum rpu_oper_mode {
> --
> 2.25.1
>