[PATCH v4 0/8] Tidy some minor things in the stream table/cd table area

Will Deacon will at kernel.org
Mon Sep 9 09:15:46 PDT 2024


On Fri, 06 Sep 2024 12:47:47 -0300, Jason Gunthorpe wrote:
> Will pointed out that two places referring to the CD/STE struct did not
> get the new types. While auditing this code a few more oddities were
> noticed. Based on a feedback from Mostafa and Nicolin a few more things
> were fixed up too
> 
> - Use types for all the HW structures everywhere even for the L1
>   descriptors that are just a single 8 bytes. This helps with clarity of
>   what everthing is pointing at
> - Use indexing helpers for the STE/CD two level calculations
> - Use sizeof(struct X) instead of open coded math on constants. The sizeof
>   naturally follows the type of the related variable in almost all cases
> - Remove redundant dma_addr_t's and save some memory
> - Remove redundant devm usage
> - Use the modern rbtree API
> 
> [...]

Thanks Jason, I like the look of this a lot more now.

Applied to will (for-joerg/arm-smmu/updates), thanks!

[1/8] iommu/arm-smmu-v3: Add arm_smmu_strtab_l1/2_idx()
      https://git.kernel.org/will/c/ce410410f1a7
[2/8] iommu/arm-smmu-v3: Add types for each level of the 2 level stream table
      https://git.kernel.org/will/c/abb4f9d323a8
[3/8] iommu/arm-smmu-v3: Reorganize struct arm_smmu_strtab_cfg
      https://git.kernel.org/will/c/85196f54743d
[4/8] iommu/arm-smmu-v3: Remove strtab_base/cfg
      https://git.kernel.org/will/c/8c153ef95697
[5/8] iommu/arm-smmu-v3: Do not use devm for the cd table allocations
      https://git.kernel.org/will/c/47b2de35cab2
[6/8] iommu/arm-smmu-v3: Shrink the cdtab l1_desc array
      https://git.kernel.org/will/c/c0a25a96dee9
[7/8] iommu/arm-smmu-v3: Add types for each level of the CD table
      https://git.kernel.org/will/c/7c567eb1e1d2
[8/8] iommu/arm-smmu-v3: Reorganize struct arm_smmu_ctx_desc_cfg
      https://git.kernel.org/will/c/e3b1be2e73db

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev



More information about the linux-arm-kernel mailing list