[PATCH 2/2] ASoC: dt-bindings: microchip,sama7g5-i2smcc: Add 'sound-name-prefix' property

[Krzysztof Kozlowski]

On 09/09/2024 10:35, Andrei Simion wrote:
> From: Codrin Ciubotariu <codrin.ciubotariu at microchip.com>
> 
> Add 'sound-name-prefix' property to differentiate between interfaces in
> DPCM use-cases. Property is optional.
> 
> [andrei.simion at microchip.com: Adjust the commit title and message.
> Reword the description for 'sound-name-prefix'.]
> 
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu at microchip.com>
> Signed-off-by: Andrei Simion <andrei.simion at microchip.com>
> ---
>  .../bindings/sound/microchip,sama7g5-i2smcc.yaml           | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml b/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml
> index fb630a184350..ad34df67c7c0 100644
> --- a/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml
> +++ b/Documentation/devicetree/bindings/sound/microchip,sama7g5-i2smcc.yaml
> @@ -52,6 +52,13 @@ properties:
>        - const: gclk
>      minItems: 1
>  
> +  sound-name-prefix:
> +    pattern: "^I2SMCC[0-9]$"

This does not look correct. Name/prefix can be anything matching real
hardware, why are you restricting it? How can you predict all names?

> +    $ref: /schemas/types.yaml#/definitions/string
> +    description:
> +      Unique prefixes for the sink/source names of the component, ensuring
> +      distinct identification among multiple instances.

You are duplicating property definitions. This is not needed at all.
Maybe your schema misses $ref to common schema.


Best regards,
Krzysztof