[PATCH v2 2/3] spi: fspi: add support for imx8ulp

[Frank Li]

On Thu, Sep 05, 2024 at 01:49:03AM +0000, Bough Chen wrote:
>
> > -----Original Message-----
> > From: Fabio Estevam <festevam at gmail.com>
> > Sent: 2024年9月5日 9:38
> > To: Bough Chen <haibo.chen at nxp.com>
> > Cc: Han Xu <han.xu at nxp.com>; yogeshgaur.83 at gmail.com;
> > broonie at kernel.org; robh at kernel.org; krzk+dt at kernel.org;
> > conor+dt at kernel.org; shawnguo at kernel.org; s.hauer at pengutronix.de;
> > kernel at pengutronix.de; singh.kuldeep87k at gmail.com; hs at denx.de;
> > linux-spi at vger.kernel.org; devicetree at vger.kernel.org;
> > linux-kernel at vger.kernel.org; imx at lists.linux.dev;
> > linux-arm-kernel at lists.infradead.org
> > Subject: Re: [PATCH v2 2/3] spi: fspi: add support for imx8ulp
> >
> > Hi Haibo,
> >
> > On Wed, Sep 4, 2024 at 10:26 PM <haibo.chen at nxp.com> wrote:
> >
> > > @@ -373,6 +367,16 @@ static struct nxp_fspi_devtype_data imx8dxl_data =
> > {
> > >         .txfifo = SZ_1K,        /* (128 * 64 bits)  */
> > >         .ahb_buf_size = SZ_2K,  /* (256 * 64 bits)  */
> > >         .quirks = FSPI_QUIRK_USE_IP_ONLY,
> > > +       .lut_num = 32,
> > > +       .little_endian = true,  /* little-endian    */
> >
> > The addition of little_endian to imx8dl should be a separate patch.
>
> Hi Fabio,
>
> I only add the .lut_num here, do not touch .lettle_endian here, and I add another 8ulp in the follow line, but format patch show in this way. Anything I can do to adjust how to format patch?

you can try below diff option.
  --patience
           Generate a diff using the "patience diff" algorithm.

  --histogram
           Generate a diff using the "histogram diff" algorithm.

  --anchored=<text>
           Generate a diff using the "anchored diff" algorithm.

I suggest split to two patches, one patch convert to hardcode 16 to
lut_num, no function change.  The other one is add 7ulp part.

Frank

>
> Best Regards
> Haibo Chen
> >
> > The comment is pointless too.