[PATCH v2 1/3] pmdomain: imx93-pd: replace dev_err() with dev_err_probe()

Uwe Kleine-König u.kleine-koenig at baylibre.com
Tue Sep 3 09:26:30 PDT 2024


Hello,

On Sun, Aug 25, 2024 at 04:34:00PM +0200, Dario Binacchi wrote:
> This way, the code becomes more compact, and dev_err_probe() is used in
> every error path of the probe() function.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi at amarulasolutions.com>

Another improvement worth mentioning is that the new output mentions the
error code returned by clk_bulk_prepare_enable(). If you respin this
series you might want to consider adding that to the commit log. Even
without that added:

Acked-by: Uwe Kleine-König <u.kleine-koenig at baylibre.com>

Best regards
Uwe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20240903/9ed3f813/attachment.sig>


More information about the linux-arm-kernel mailing list