[PATCH] ARM: dove: Drop a write-only variable
Gregory CLEMENT
gregory.clement at bootlin.com
Mon Sep 2 07:19:47 PDT 2024
Hi Uwe ,
> This fixes a W=1 build error:
>
> arch/arm/mach-dove/common.c: In function ‘dove_clk_init’:
> arch/arm/mach-dove/common.c:85:40: error: variable ‘gephy’ set but not used [-Werror=unused-but-set-variable]
> 85 | struct clk *xor0, *xor1, *ge, *gephy;
> | ^~~~~
>
> Fixes: 521674718af0 ("ARM: dove: add clock gating control")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at baylibre.com>
Applied on mvebu/arm
Thanks,
Gregory
> ---
> arch/arm/mach-dove/common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c
> index 3aea90bbb41a..35e978514591 100644
> --- a/arch/arm/mach-dove/common.c
> +++ b/arch/arm/mach-dove/common.c
> @@ -82,7 +82,7 @@ static void __init dove_clk_init(void)
> {
> struct clk *usb0, *usb1, *sata, *pex0, *pex1, *sdio0, *sdio1;
> struct clk *nand, *camera, *i2s0, *i2s1, *crypto, *ac97, *pdma;
> - struct clk *xor0, *xor1, *ge, *gephy;
> + struct clk *xor0, *xor1, *ge;
>
> tclk = clk_register_fixed_rate(NULL, "tclk", NULL, 0, dove_tclk);
>
> @@ -102,7 +102,7 @@ static void __init dove_clk_init(void)
> pdma = dove_register_gate("pdma", "tclk", CLOCK_GATING_BIT_PDMA);
> xor0 = dove_register_gate("xor0", "tclk", CLOCK_GATING_BIT_XOR0);
> xor1 = dove_register_gate("xor1", "tclk", CLOCK_GATING_BIT_XOR1);
> - gephy = dove_register_gate("gephy", "tclk", CLOCK_GATING_BIT_GIGA_PHY);
> + dove_register_gate("gephy", "tclk", CLOCK_GATING_BIT_GIGA_PHY);
> ge = dove_register_gate("ge", "gephy", CLOCK_GATING_BIT_GBE);
>
> orion_clkdev_add(NULL, "orion_spi.0", tclk);
>
> base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
> --
> 2.43.0
More information about the linux-arm-kernel
mailing list