[PATCH V5 0/4] arm-cs-trace-disasm.py/perf must accommodate non-zero DSO text offset
Leo Yan
leo.yan at arm.com
Sun Sep 1 06:53:29 PDT 2024
Hi Steve,
On 8/31/2024 8:19 PM, Steve Clevenger wrote:
[...]
> Hi Leo,
>
> That's great. Unfortuantely, I need to submit a V6 for patch 4/4, which
> is the arm-cs-trace-disasm.py script. Kernel instruction trace requires
> zeroing map_pgoff. perf makes most offset decisions, but this one is in
> the script. It's a one liner.
Agreed the kernel symbols should be zero map offset.
Thanks for correcting this.
> I know you're a b4 fan, but I've never used it. If I'm able to make
> progress with it I'll use it to resubmit. Otherwise more of the same.
For using the b4 command:
$ b4 am <Message-ID>
You can find the message ID in the lore webpage, e.g. for this series,
in the cover letter link [1], click the 'raw' hyper link, then you can
fine the Message ID is:
cover.1724879699.git.scclevenger at os.amperecomputing.com
Run 'b4 am cover.1724879699.git.scclevenger at os.amperecomputing.com' for
downloading the patches (with automatic amending ACK and review tags).
As result, you will get the file:
v5_20240828_scclevenger_arm_cs_trace_disasm_py_perf_must_accommodate_non_zero_dso_text_offset.mbx
$ git am v5_20240828_scclevenger_arm_cs_trace_disasm_py_perf_must_accommodate_non_zero_dso_text_offset.mbx
Alternatively, if you are using new b4 version, you can directly use
the command 'b4 shazam <Message-ID>' for downloading series and applying
it on your local branch in one go.
I tried the b4 command for your series but failed, I can see you used `git
send-email` but the series was not discontinuous so b4 command cannot fetch
the whole series.
You can just work on you existed patches - don't forget to append my review
tags for patches 01 ~ 03. For the patch 04, after you send out I will review
it.
Thanks,
Leo
[1] https://lore.kernel.org/linux-perf-users/7a2c53c0-0bac-4a53-824d-6efdff8ed3ce@os.amperecomputing.com/T/#mc76180d8076cf3414ba81e7c379cda93297aa4a9
More information about the linux-arm-kernel
mailing list