[PATCH net-next v7 3/8] net: stmmac: Refactor FPE functions to generic version

[Vladimir Oltean]

On Thu, Oct 31, 2024 at 08:37:57PM +0800, Furong Xu wrote:
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.h b/drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.h
> index 25725fd5182f..15fcb9ef1a97 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.h
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.h
> @@ -12,34 +12,22 @@
>  #define STMMAC_FPE_MM_MAX_VERIFY_RETRIES	3
>  #define STMMAC_FPE_MM_MAX_VERIFY_TIME_MS	128
>  
> -/* FPE link-partner hand-shaking mPacket type */
> -enum stmmac_mpacket_type {
> -	MPACKET_VERIFY = 0,
> -	MPACKET_RESPONSE = 1,
> -};
> -
>  struct stmmac_priv;
>  struct stmmac_fpe_cfg;

With the removal of the dwmac5_*() and dwxgmac3_*() functions, the
forward definition of struct stmmac_fpe_cfg has no user in stmmac_fpe.h.

>  
>  void stmmac_fpe_link_state_handle(struct stmmac_priv *priv, bool is_up);
> -void stmmac_fpe_event_status(struct stmmac_priv *priv, int status);
>  void stmmac_fpe_init(struct stmmac_priv *priv);
>  void stmmac_fpe_apply(struct stmmac_priv *priv);
> +void stmmac_fpe_configure(struct stmmac_priv *priv, bool tx_enable,
> +			  bool pmac_enable);

I'm not sure why I missed this during v6, but stmmac_fpe_configure() is
only called from within stmmac_fpe.c, and thus should be static.