回复: [EXT] Re: [PATCH v3] soc: imx: Add SoC device register for i.MX9

[Alice Guo (OSS)]

Hi Stefan,

> -----邮件原件-----
> 发件人: Stefan Wahren <wahrenst at gmx.net>
> 发送时间: 2024年10月30日 19:54
> 收件人: Alice Guo (OSS) <alice.guo at oss.nxp.com>;
> alexander.stein at ew.tq-group.com; shawnguo at kernel.org;
> s.hauer at pengutronix.de; kernel at pengutronix.de; festevam at gmail.com
> 抄送: imx at lists.linux.dev; linux-arm-kernel at lists.infradead.org;
> linux-kernel at vger.kernel.org; Alice Guo <alice.guo at nxp.com>
> 主题: [EXT] Re: [PATCH v3] soc: imx: Add SoC device register for i.MX9
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> Hi Alice,
> 
> Am 30.10.24 um 10:13 schrieb alice.guo at oss.nxp.com:
> > From: "alice.guo" <alice.guo at nxp.com>
> >
> > i.MX9 SoCs have SoC ID, SoC revision number and chip unique identifier
> > which are provided by the corresponding ARM trusted firmware API. This
> > patch intends to use SMC call to obtain these information and then
> > register i.MX9 SoC as a device.
> >
> > Signed-off-by: alice.guo <alice.guo at nxp.com>
> > ---
> >
> > Changes for v2:
> >   - refine error log print
> > Changes for v3:
> >   - return -EINVAL when arm_smccc_smc failed
> >   - fix the build warning caused by pr_err("%s: SMC failed: %d\n", __func__,
> res.a0);
> >   - drop the pr_err in imx9_soc_init
> >   - free the memory in the reverse order of allocation
> >   - use of_match_node instead of of_machine_is_compatible
> >
> >   drivers/soc/imx/Makefile   |   2 +-
> >   drivers/soc/imx/soc-imx9.c | 106
> +++++++++++++++++++++++++++++++++++++
> >   2 files changed, 107 insertions(+), 1 deletion(-)
> >   create mode 100644 drivers/soc/imx/soc-imx9.c
> >
> > diff --git a/drivers/soc/imx/Makefile b/drivers/soc/imx/Makefile index
> > 3ad321ca608a..ca6a5fa1618f 100644
> > --- a/drivers/soc/imx/Makefile
> > +++ b/drivers/soc/imx/Makefile
> > @@ -3,4 +3,4 @@ ifeq ($(CONFIG_ARM),y)
> >   obj-$(CONFIG_ARCH_MXC) += soc-imx.o
> >   endif
> >   obj-$(CONFIG_SOC_IMX8M) += soc-imx8m.o
> > -obj-$(CONFIG_SOC_IMX9) += imx93-src.o
> > +obj-$(CONFIG_SOC_IMX9) += imx93-src.o soc-imx9.o
> > diff --git a/drivers/soc/imx/soc-imx9.c b/drivers/soc/imx/soc-imx9.c
> > new file mode 100644 index 000000000000..823395584533
> > --- /dev/null
> > +++ b/drivers/soc/imx/soc-imx9.c
> > @@ -0,0 +1,106 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright 2024 NXP
> > + */
> > +
> > +#include <linux/arm-smccc.h>
> > +#include <linux/init.h>
> > +#include <linux/module.h>
> > +#include <linux/of.h>
> > +#include <linux/slab.h>
> > +#include <linux/sys_soc.h>
> > +
> > +#define IMX_SIP_GET_SOC_INFO 0xc2000006
> > +#define SOC_ID(x)            (((x) & 0xFFFF) >> 8)
> > +#define SOC_REV_MAJOR(x)     ((((x) >> 28) & 0xF) - 0x9)
> > +#define SOC_REV_MINOR(x)     (((x) >> 24) & 0xF)
> > +
> > +static int imx9_soc_device_register(void) {
> > +     struct soc_device_attribute *attr;
> > +     struct arm_smccc_res res;
> > +     struct soc_device *sdev;
> > +     u32 soc_id, rev_major, rev_minor;
> > +     u64 uid127_64, uid63_0;
> > +     int err;
> > +
> > +     attr = kzalloc(sizeof(*attr), GFP_KERNEL);
> > +     if (!attr)
> > +             return -ENOMEM;
> > +
> > +     err = of_property_read_string(of_root, "model", &attr->machine);
> > +     if (err) {
> > +             pr_err("%s: missing model property: %d\n", __func__, err);
> > +             goto attr;
> > +     }
> > +
> > +     attr->family = kasprintf(GFP_KERNEL, "Freescale i.MX");
> > +
> > +     /*
> > +      * Retrieve the soc id, rev & uid info:
> > +      * res.a1[31:16]: soc revision;
> > +      * res.a1[15:0]: soc id;
> > +      * res.a2: uid[127:64];
> > +      * res.a3: uid[63:0];
> > +      */
> > +     arm_smccc_smc(IMX_SIP_GET_SOC_INFO, 0, 0, 0, 0, 0, 0, 0, &res);
> > +     if (res.a0 != SMCCC_RET_SUCCESS) {
> > +             pr_err("%s: SMC failed: 0x%lx\n", __func__, res.a0);
> > +             err = -EINVAL;
> > +             goto family;
> > +     }
> > +
> > +     soc_id = SOC_ID(res.a1);
> > +     rev_major = SOC_REV_MAJOR(res.a1);
> > +     rev_minor = SOC_REV_MINOR(res.a1);
> > +
> > +     attr->soc_id = kasprintf(GFP_KERNEL, "i.MX%2x", soc_id);
> > +     attr->revision = kasprintf(GFP_KERNEL, "%d.%d", rev_major,
> > + rev_minor);
> > +
> > +     uid127_64 = res.a2;
> > +     uid63_0 = res.a3;
> > +     attr->serial_number = kasprintf(GFP_KERNEL, "%016llx%016llx",
> > + uid127_64, uid63_0);
> > +
> > +     sdev = soc_device_register(attr);
> > +     if (IS_ERR(sdev)) {
> > +             err = PTR_ERR(sdev);
> > +             pr_err("%s failed to register SoC as a device: %d\n", __func__,
> err);
> > +             goto serial_number;
> > +     }
> > +
> > +     return 0;
> > +
> > +serial_number:
> > +     kfree(attr->serial_number);
> > +     kfree(attr->revision);
> > +     kfree(attr->soc_id);
> > +family:
> > +     kfree(attr->family);
> > +attr:
> > +     kfree(attr);
> > +     return err;
> > +}
> > +
> > +static const struct of_device_id imx9_soc_match[] = {
> > +     { .compatible = "fsl,imx93", },
> > +     { .compatible = "fsl,imx95", },
> What happend to fsl,imx91 ?

I forgot to mention this change in change log. The code about i.MX91 will be public later.

Best Regards,
Alice Guo

> Best regards