[PATCH v3] dt-bindings: power: Convert raspberrypi,bcm2835-power to Dt schema
Krzysztof Kozlowski
krzk at kernel.org
Sun Oct 27 13:29:56 PDT 2024
On Sat, Oct 26, 2024 at 01:59:13PM +0000, Karan Sanghavi wrote:
> Convert the raspberrypi,bcm2835-power binding to Dt schema
>
> Signed-off-by: Karan Sanghavi <karansanghvi98 at gmail.com>
> ---
> Changes in v3:
> - Applied changes as per the feedback received for title and description
> - Removed power label and renamed node to power-controller
> - Moved the file from bindings/soc/bcm to bindings/power
> - Link to v2: https://lore.kernel.org/r/20241022-raspberrypi-bcm2835-power-v2-1-1a4a8a8a5737@gmail.com
>
> Changes in v2:
> - Added original file maintainers
> - Removed unnecessary headers from example and formating from description
> - Link to v1: https://lore.kernel.org/r/20241019-raspberrypi-bcm2835-power-v1-1-75e924dc3745@gmail.com
> ---
> .../bindings/power/raspberrypi,bcm2835-power.yaml | 44 ++++++++++++++++++++
> .../bindings/soc/bcm/raspberrypi,bcm2835-power.txt | 47 ----------------------
> 2 files changed, 44 insertions(+), 47 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/raspberrypi,bcm2835-power.yaml b/Documentation/devicetree/bindings/power/raspberrypi,bcm2835-power.yaml
> new file mode 100644
> index 000000000000..71b3fa41c495
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/raspberrypi,bcm2835-power.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +
Some random changes... this wasn't in previous version
> +---
> +
Neither this.
> +$id: http://devicetree.org/schemas/power/raspberrypi,bcm2835-power.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM2835 power domain
> +
> +maintainers:
> + - Alexander Aring <alex.aring at gmail.com>
> + - Eric Anholt <eric at anholt.net>
> +
> +description:
> + The Raspberry Pi power domain manages power for various subsystems
> + in the Raspberry Pi BCM2835 SoC.
> +
> +properties:
> + compatible:
> + enum:
> + - raspberrypi,bcm2835-power
> +
> + firmware:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Reference to the RPi firmware device node
> +
> + "#power-domain-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - firmware
> + - "#power-domain-cells"
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + power-controller {
> + compatible = "raspberrypi,bcm2835-power";
> + firmware = <&firmware>;
> + #power-domain-cells = <1>;
> + };
Nor this misindent.
Your task was to do 'mv', not rewrite the patch. How random differences
could appear here?
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list