[PATCH net v2] net: ti: icssg-prueth: Fix 1 PPS sync

Meghana Malladi m-malladi at ti.com
Thu Oct 24 22:47:44 PDT 2024



On 25/10/24 01:25, Andrew Lunn wrote:
>> +static inline u64 icssg_readq(const void __iomem *addr)
>> +{
>> +	return readl(addr) + ((u64)readl(addr + 4) << 32);
>> +}
>> +
>> +static inline void icssg_writeq(u64 val, void __iomem *addr)
>> +{
>> +	writel(lower_32_bits(val), addr);
>> +	writel(upper_32_bits(val), addr + 4);
>> +}
> 
> Could readq() and writeq() be used, rather than your own helpers?
> 
> 	Andrew
> 
The addresses we are trying to read here are not 64-bit aligned, hence 
using our own helpers to read the 64-bit value.

Regards,
Meghana



More information about the linux-arm-kernel mailing list