[PATCH 4/8] drivers/perf: hisi: Add a common function to retrieve topology from firmware

[Jonathan Cameron]

On Fri, 18 Oct 2024 17:57:41 +0800
Yicong Yang <yangyicong at huawei.com> wrote:

> From: Yicong Yang <yangyicong at hisilicon.com>
> 
> Currently each type of uncore PMU driver uses almost the same routine
> and the same firmware interface (or properties) to retrieve the topology
> information, then reset the unused IDs to -1. Extract the common parts
> to the framework in hisi_uncore_pmu_init_topology().
> 
> Signed-off-by: Yicong Yang <yangyicong at hisilicon.com>
Patch looks good to me

Reviewed-by: Jonathan Cameron <Jonathan.Cameron at huawei.com>

but it did leave me wondering why there was no removal of property.h
from some of the drivers now all the property stuff is central.

Seems they don't include, it but do include acpi.h which they
should not.  So a nice follow up would be to drop the acpi.h
includes in favour of mod_devicetable.h which is needed
for the id tables.

Jonathan