[PATCH 2/2] pwm: Add Nuvoton PWM controller support

Chi-Wen Weng cwweng.linux at gmail.com
Fri Oct 18 03:29:07 PDT 2024


Hi Krzysztof,

Thank you for your reply.


On 2024/10/18 下午 02:01, Krzysztof Kozlowski wrote:
> On 18/10/2024 05:48, Chi-Wen Weng wrote:
>> This commit adds a generic PWM framework driver for Nuvoton MA35D1
>> PWM controller.
>>
>> Signed-off-by: Chi-Wen Weng <cwweng.linux at gmail.com>
>
> ...
>
>
>> +
>> +static const struct of_device_id nuvoton_pwm_of_match[] = {
>> +	{ .compatible = "nuvoton,ma35d1-pwm" },
>> +	{}
>> +};
>> +MODULE_DEVICE_TABLE(of, nuvoton_pwm_of_match);
>> +
>> +static struct platform_driver nuvoton_pwm_driver = {
>> +	.probe = nuvoton_pwm_probe,
>> +	.driver = {
>> +		.name = "nuvoton-pwm",
>> +		.of_match_table = nuvoton_pwm_of_match,
>> +	},
>> +};
>> +module_platform_driver(nuvoton_pwm_driver);
>> +
>> +MODULE_ALIAS("platform:nuvoton-pwm");
> Drop, not needed and not correct either. If you need platform alias for
> non-OF binds, this is supposed to match OF ID table.
Ok. I will drop it.
>> +MODULE_AUTHOR("Chi-Wen Weng <cwweng at nuvoton.com>");
>> +MODULE_DESCRIPTION("Nuvoton MA35D1 PWM driver");
>> +MODULE_LICENSE("GPL");
> Best regards,
> Krzysztof

Thanks.

Chi-Wen Weng




More information about the linux-arm-kernel mailing list