[PATCH 1/5] arm64: signal: Remove unused macro

Dave Martin Dave.Martin at arm.com
Thu Oct 17 08:49:29 PDT 2024


On Thu, Oct 17, 2024 at 02:39:05PM +0100, Kevin Brodsky wrote:
> Commit 33f082614c34 ("arm64: signal: Allow expansion of the signal
> frame") introduced the BASE_SIGFRAME_SIZE macro but it has
> apparently never been used.

Nit: Should there be a statement of what the patch does?

Same throughout the series.

(Yes, I know it's in the subject line, but Mutt doesn't think that's
part of the message body, so I can't see it now that I'm replying...
and submitting-patches.rst and e.g., maintainer-tip.rst seem to take
the same policy, albeit without quite stating it explicitly.)

> Signed-off-by: Kevin Brodsky <kevin.brodsky at arm.com>

Weird.  Maybe there are places where this could have been used, but I
guess we have managed fine without it.

Or possibly some unmerged version of the SVE patches used this but it
disappeared in refactoring.

Either way:

Reviewed-by: Dave Martin <Dave.Martin at arm.com>

> ---
>  arch/arm64/kernel/signal.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/signal.c b/arch/arm64/kernel/signal.c
> index 561986947530..dc998326e24d 100644
> --- a/arch/arm64/kernel/signal.c
> +++ b/arch/arm64/kernel/signal.c
> @@ -66,7 +66,6 @@ struct rt_sigframe_user_layout {
>  	unsigned long end_offset;
>  };
>  
> -#define BASE_SIGFRAME_SIZE round_up(sizeof(struct rt_sigframe), 16)
>  #define TERMINATOR_SIZE round_up(sizeof(struct _aarch64_ctx), 16)
>  #define EXTRA_CONTEXT_SIZE round_up(sizeof(struct extra_context), 16)
>  
> -- 
> 2.43.0
> 
> 



More information about the linux-arm-kernel mailing list