[PATCH] firmware: arm_scmi: fix the double free in scmi_debugfs_common_setup()
Cristian Marussi
cristian.marussi at arm.com
Fri Oct 11 07:25:25 PDT 2024
On Fri, Oct 11, 2024 at 06:40:02PM +0800, Su Hui wrote:
> Clang static checker(scan-build) warning:
> drivers/firmware/arm_scmi/driver.c:line 2915, column 2
> Attempt to free released memory.
>
> When devm_add_action_or_reset() failed , scmi_debugfs_common_cleanup()
> will run twice which caused double free of 'dbg->name'.
> Remove the redundant scmi_debugfs_common_cleanup() to fix this problem.
>
Oh Yes...my bad, Good Catch !
LGTM.
Reviewed-by: Cristian Marussi <cristian.marussi at arm.com>
Thanks,
Cristian
More information about the linux-arm-kernel
mailing list