[PATCH v2] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy
AngeloGioacchino Del Regno
angelogioacchino.delregno at collabora.com
Tue Oct 8 02:09:08 PDT 2024
Il 08/10/24 09:15, Macpaul Lin ha scritto:
> The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error.
> The error message was:
> t-phy at 11e30000: 'power-domains' does not match any of the regexes:
> '^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
> Fix this issue by dropping 'power-domains' of u3phy1 node.
>
> This is because MediaTek tphy dose not need to add mtcmos. It is not
> necessary to add 'power-domains'. If the power of the tphy is turned off,
> it will affect other functions. From the current USB hardware design
> perspective, even if mtcmos is added to the phy, it is always on.
>
> Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and evaluation board")
> Signed-off-by: Macpaul Lin <macpaul.lin at mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> Changes for v2:
> - Add detail description of the tphy design for explaining the reason
> of this change.
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index ade685ed2190..1c6f08dde31c 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -1920,7 +1920,6 @@ u3phy1: t-phy at 11e30000 {
> #address-cells = <1>;
> #size-cells = <1>;
> ranges = <0 0 0x11e30000 0xe00>;
> - power-domains = <&spm MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY>;
> status = "disabled";
>
> u2port1: usb-phy at 0 {
More information about the linux-arm-kernel
mailing list