Re: 回覆: [PATCH v1 01/10] dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700 SCU

Krzysztof Kozlowski krzk at kernel.org
Mon Oct 7 04:03:58 PDT 2024


On 07/10/2024 13:03, Krzysztof Kozlowski wrote:
> On 15/08/2024 07:50, Kevin Chen wrote:
>> Hi Krzk,
>>
>> I will speperate clock part in the v3 patch into Ryan's clock series.
>>
>>> Missing commit msg.
>>>
>>> Please use subject prefixes matching the subsystem. You can get them for
>>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
>>> your patch is touching. For bindings, the preferred subjects are
>>> explained here:
>>> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>>>
>>> A nit, subject: drop second/last, redundant "bindings for". The
>>> "dt-bindings" prefix is already stating that these are bindings.
>>> See also:
>>> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
>> Agree, already fixed in another commit in Ryan's series.
>> [1/4] dt-bindings: mfd: aspeed: support fo
> 
> Just to make it clear: you responded after 2.5 months. This patchset is
> neither in my mailbox nor in my brain.

Uh, this was supposed to be replied to your recent emails.

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list